Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add filters for container state to docker input #3950

Merged
merged 4 commits into from
Mar 30, 2018

Conversation

danielnelson
Copy link
Contributor

closes #2737

Required for all PRs:

  • Signed CLA.
  • Associated README.md updated.
  • Has appropriate unit tests.

@danielnelson danielnelson added feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin area/docker labels Mar 29, 2018
@danielnelson danielnelson added this to the 1.6.0 milestone Mar 29, 2018
@danielnelson
Copy link
Contributor Author

@m4ce While I was working on this I was able to reproduce reporting of exited containers, which I found strange because I was pretty sure I had verified the original bug report. At any rate this pull request adds filtering options on a per state basis, but are you still seeing the original issue reported in #2737?

@m4ce
Copy link
Contributor

m4ce commented Mar 30, 2018

@danielnelson, I occasionally see this issue. I limited the impact by filtering on container names. However, it's only a workaround.

@danielnelson danielnelson merged commit 971debb into master Mar 30, 2018
@danielnelson danielnelson deleted the docker-container-state branch March 30, 2018 20:17
@danielnelson
Copy link
Contributor Author

@m4ce Strange... hopefully this patch will be a better solution for you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/docker feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Docker input: disable metrics reporting for non-running containers
2 participants