Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added additional SQL Server performance counters #3770

Merged
merged 4 commits into from
Feb 9, 2018

Conversation

m82labs
Copy link
Contributor

@m82labs m82labs commented Feb 8, 2018

Required for all PRs:

  • Signed CLA.
  • Associated README.md updated.
  • Has appropriate unit tests.

I added the following new counters to the performance counter query:

  • SQLServer:Resource Pool Stats
    • Active memory grant amount (KB)
    • Disk Read Bytes/sec
    • Disk Read IO Throttled/sec
    • Disk Read IO/sec
    • Disk Write Bytes/sec
    • Disk Write IO Throttled/sec
    • Disk Write IO/sec
    • Used memory (KB)
  • SQLServer:User Settable
    • All
  • SQLServer:SQL Errors
    • All
  • SQLServer:Databases\Backup/Restore Throughput/sec
  • SQLServer:Memory Manager\Target Server Memory (KB)
  • SQLServer:Memory Manager\Total Server Memory (KB)

This was based on feedback from my previous pull request and internal feedback. I also removed the 'c_type' tag from the performance counter query and add documentation to the readme about which counters need delta calculations and which dont.

@m82labs
Copy link
Contributor Author

m82labs commented Feb 8, 2018

@kerams I added Target and Total Server Memory and removed the c_type tag. I also added some more counters I think people might find useful including the user settable counters.

@kerams
Copy link
Contributor

kerams commented Feb 8, 2018

Kickass.

@danielnelson danielnelson added this to the 1.6.0 milestone Feb 9, 2018
@danielnelson danielnelson added the feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin label Feb 9, 2018
@danielnelson danielnelson merged commit 42ccc9f into influxdata:master Feb 9, 2018
mkboudreau added a commit to mkboudreau/telegraf that referenced this pull request Feb 16, 2018
* master: (59 commits)
  Added additional SQL Server performance counters (influxdata#3770)
  Update changelog
  Fix ping plugin not reporting zero durations (influxdata#3778)
  Adjust time of nightly build
  Update changelog
  Add TLS support to the mesos input plugin (influxdata#3769)
  Install new requirements for fpm gem install
  Update changelog
  Add additional metrics and reverse metric names option to openldap (influxdata#3722)
  Update paho mqtt to latest release
  Update changelog
  Remove userinfo from url tag in prometheus input (influxdata#3743)
  Update sample config in contributing docs
  Run nightly build sequentially
  Fix Makefile on Windows and use in AppVeyor build (influxdata#3748)
  Fix example source_override values in wavefront output (influxdata#3744)
  Update gitignore
  Update changelog
  Improve procstat readme
  Add native Go method for finding pids to procstat (influxdata#3559)
  ...
maxunt pushed a commit that referenced this pull request Jun 26, 2018
* Included system databases in server properties, added backup/restore throughput counter, error counters, and user settable counters.

* Added more resource governor counters.

* Added Target and Total Server Memory counters.

* Removed the c_type tag from the performance counters query, added more documentation instead.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants