fix postfix plugin age to use ctime, not mtime #3525
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
postfix modifies file mtime to track when the message should be retried (http://www.postfix.org/TUNING_README.html#hammer): > the queue manager gives the queue file a time stamp into the future, so it won't be looked at for a while So this change uses the file's ctime instead of mtime.
aromeyer
pushed a commit
to aromeyer/telegraf
that referenced
this pull request
May 19, 2018
maxunt
pushed a commit
that referenced
this pull request
Jun 26, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3521
Unfortunately ctime is not supported on all platforms, but I think the only such platform is windows, which doesn't support postfix anyway. However there are 2 different methods of getting ctime among the unix platforms, so I had to add conditional build tags to the different methods. You also cannot manually set a file's ctime, so we can't test it very well :-/
Required for all PRs: