Added response_timeout property to prometheus input plugin #2006
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
puckpuck
changed the title
sparrc
suggested changes
Dec 16, 2016
| @@ -21,6 +21,8 @@ type Prometheus struct { | |||
| // Bearer Token authorization file path | |||
| BearerToken string `toml:"bearer_token"` | |||
|
|
|||
| ResponseTimeout int `toml:"response_timeout"` | |||
There was a problem hiding this comment.
make ResponseTimeout an internal.Duration type
| @@ -38,6 +40,9 @@ var sampleConfig = ` | |||
| ## Use bearer token for authorization | |||
| # bearer_token = /path/to/bearer/token | |||
|
|
|||
| ## Specify timeout in seconds for slower prometheus clients (default is 3) | |||
| # response_timeout = 3 | |||
There was a problem hiding this comment.
once ResponseTimeout is an internal.Duration type, it can be written as response_timeout = "3s"
sparrc
approved these changes
Dec 17, 2016
njwhite
pushed a commit
to njwhite/telegraf
that referenced
this pull request
Jan 31, 2017
maxunt
pushed a commit
that referenced
this pull request
Jun 26, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Required for all PRs:
While working with a customer to setup monitoring, leveraging their existing Prometheus endpoints to gather metrics, we were getting numerous timeout errors in the logs. Upon further investigation, the prometheus input plugin has a 3 second timeout hard coded. The issue is that some of the prometheus endpoints were taking much longer than 3 seconds to return all available metrics. We converted this to a configuration property, with a default value of 3 seconds, which ultimately solved the problem.
Since the default is still 3 seconds, this should be a non-breaking change.