-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added amqp output #200
Added amqp output #200
Conversation
t.Skip("Skipping integration test in short mode") | ||
} | ||
|
||
var url = "amqp://" + testutil.GetLocalHost() + ":5672/" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like you are following the form of the kafka output plugin here. In the case of kafka, we've added a kafka broker to the scripts/docker-compose.yml
file that the test is connecting to in long mode. I'm not very familiar with AMQP, but is there a similar machine that you could add to the dockerfile? Would a rabbitmq docker container work? I think something like this should work:
rabbitmq:
image: rabbitmq:3-management
hostname: docker_rabbit
ports:
- "15672:15672"
- "5672:5672"
see long unit tests section of readme for more details: https://github.com/influxdb/telegraf/blob/master/CONTRIBUTING.md#execute-long-tests
Could you write a short README for this? See #177 |
This looks great! Thank you very much! Please just address the comments that I've left and I can merge it 👍 |
Thanks for feedback, Cameron! I've corrected typos and added README, but I have one conflict now. |
@ekini thanks much for your contribution! I made some tweaks to the documentation and changed the default RoutingTag to "host" instead of "dc", because I thought it would be better to use a tag that is defined by default. I liked that idea so I also added that same functionality to the Kafka output, since that was just hardcoded to use "host" before. |
Is it possible to use SSL/Certificates with rabbit.output ? |
Yes, I'm going to add it in a week.
|
Please, review my amqp output plugin.