fix puppetagent inputs plugin to support strings for config variable for environments #1917
Conversation
frankxoom
changed the title
|
can you explain what this change is about? why is it necessary? has a puppet agent field changed in a newer version? |
|
@frankxoom nevermind, Sean pointed to the zendesk ticket referencing this. I agree that this field should be a string, but unfortunately this would be a breaking change for anyone currently using the plugin. They will receive an error saying that the for this reason, could you also change the name of the field to You'll also need to get the unit tests passing before I can merge. |
|
@sparrc I made the changes you suggested, and the unit tests have passed. Let me know if there is something else you would like changed. Thanks for your assistance. --Frank Stutz |
| @@ -68,8 +68,8 @@ type time struct { | |||
| } | |||
|
|
|||
| type version struct { | |||
| Config string `yaml:"config"` | |||
| Puppet string `yaml:"puppet"` | |||
| Config_string string `yaml:"config"` | |||
There was a problem hiding this comment.
this should be ConfigString
| @@ -68,8 +68,8 @@ type time struct { | |||
| } | |||
|
|
|||
| type version struct { | |||
| Config int64 `yaml:"config"` | |||
| Puppet string `yaml:"puppet"` | |||
| Config_string string `yaml:"config"` | |||
There was a problem hiding this comment.
this should be ConfigString
|
thanks @frankxoom update the casing, sign the CLA, and update the changelog and I can merge this |
|
Okay, I updated casing, changelog (I put in 1.2 since you put in that milestone), and signed CLA. Thanks for your help. |
put Makefile back to normal removed comment from puppetagent.go changed config_version to config_version_string and fixed yaml for build changed workind from branch to environment for config_string fixed casing and Changelog fixed test case closes influxdata#1917
put Makefile back to normal removed comment from puppetagent.go changed config_version to config_version_string and fixed yaml for build changed workind from branch to environment for config_string fixed casing and Changelog fixed test case closes #1917
Required for all PRs: