logparser: allow numbers in ident & auth parameters #1864
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phemmer
reviewed
Oct 7, 2016
| @@ -53,7 +53,7 @@ RESPONSE_TIME %{DURATION:response_time_ns:duration} | |||
| EXAMPLE_LOG \[%{HTTPDATE:ts:ts-httpd}\] %{NUMBER:myfloat:float} %{RESPONSE_CODE} %{IPORHOST:clientip} %{RESPONSE_TIME} | |||
|
|
|||
| # Wider-ranging username matching vs. logstash built-in %{USER} | |||
| NGUSERNAME [a-zA-Z\.\@\-\+_%]+ | |||
| NGUSERNAME [a-zA-Z0-9\.\@\-\+_%]+ | |||
There was a problem hiding this comment.
Just curious, if the field is delimited by spaces, why not match any non-space character?
There was a problem hiding this comment.
no particular reason, I'm just following logstash's example: https://github.com/elastic/logstash/blob/v1.4.2/patterns/grok-patterns#L1
There was a problem hiding this comment.
I've changed the COMMON LOG FORMAT pattern to match NOTSPACE for ident and auth. I wasn't able to find any information regarding character limitations on these. It appears that even whitespace is allowed based on #1810, but hopefully it's not very common.
sparrc
force-pushed
the
cs1810
branch
3 times, most recently
from
2739600
to
b768234
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Required for all PRs:
fixes #1810