Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(inputs.kinesis_consumer): Cleanup code #16267

Merged
merged 2 commits into from
Dec 11, 2024
Merged

chore(inputs.kinesis_consumer): Cleanup code #16267

merged 2 commits into from
Dec 11, 2024

Conversation

srebhan
Copy link
Member

@srebhan srebhan commented Dec 6, 2024

Summary

Cleanup code and tests. No functional changes.

Checklist

  • No AI generated code was used in this PR

Related issues

@telegraf-tiger telegraf-tiger bot added chore plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins labels Dec 6, 2024
@srebhan srebhan added the ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. label Dec 6, 2024
@srebhan srebhan mentioned this pull request Dec 6, 2024
Closed
1 task
DStrand1
DStrand1 approved these changes Dec 10, 2024
View reviewed changes
plugins/inputs/kinesis_consumer/logging.go Outdated Show resolved Hide resolved
@DStrand1 DStrand1 assigned srebhan and unassigned DStrand1 Dec 10, 2024
@srebhan @DStrand1
Update plugins/inputs/kinesis_consumer/logging.go
3168bad 
Co-authored-by: Dane Strandboge <136023093+DStrand1@users.noreply.github.com>
@telegraf-tiger
Copy link
Contributor

Download PR build artifacts for linux_amd64.tar.gz, darwin_arm64.tar.gz, and windows_amd64.zip.
Downloads for additional architectures and packages are available below.

☺️ This pull request doesn't significantly change the Telegraf binary size (less than 1%)

📦 Click here to get additional PR build artifacts

Artifact URLs

DEB RPM TAR GZ ZIP
amd64.deb aarch64.rpm darwin_amd64.tar.gz windows_amd64.zip
arm64.deb armel.rpm darwin_arm64.tar.gz windows_arm64.zip
armel.deb armv6hl.rpm freebsd_amd64.tar.gz windows_i386.zip
armhf.deb i386.rpm freebsd_armv7.tar.gz
i386.deb ppc64le.rpm freebsd_i386.tar.gz
mips.deb riscv64.rpm linux_amd64.tar.gz
mipsel.deb s390x.rpm linux_arm64.tar.gz
ppc64el.deb x86_64.rpm linux_armel.tar.gz
riscv64.deb linux_armhf.tar.gz
s390x.deb linux_i386.tar.gz
linux_mips.tar.gz
linux_mipsel.tar.gz
linux_ppc64le.tar.gz
linux_riscv64.tar.gz
linux_s390x.tar.gz

@srebhan srebhan merged commit 05435e4 into influxdata:master Dec 11, 2024
27 checks passed
@srebhan srebhan deleted the kinesis_consumer_cleanup branch December 11, 2024 20:25
@github-actions github-actions bot added this to the v1.33.1 milestone Dec 11, 2024
justinwwhuang pushed a commit to justinwwhuang/telegraf_fork that referenced this pull request Dec 19, 2024
@srebhan @DStrand1 @justinwwhuang
chore(inputs.kinesis_consumer): Cleanup code (influxdata#16267)
86e9a1e 
Co-authored-by: Dane Strandboge <136023093+DStrand1@users.noreply.github.com>
izekr pushed a commit to izekr/telegraf that referenced this pull request Dec 19, 2024
@srebhan @DStrand1 @izekri
chore(inputs.kinesis_consumer): Cleanup code (influxdata#16267)
7616270 
Co-authored-by: Dane Strandboge <136023093+DStrand1@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DStrand1 DStrand1 DStrand1 approved these changes

Assignees

@srebhan srebhan

Labels
chore plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review.
Projects
None yet
Milestone
v1.33.1
Development

Successfully merging this pull request may close these issues.
2 participants
@srebhan @DStrand1