Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(inputs.prometheus): Improve label and field selector logging #16228

Merged
merged 3 commits into from
Dec 9, 2024
Merged

chore(inputs.prometheus): Improve label and field selector logging #16228

merged 3 commits into from
Dec 9, 2024

Conversation

DStrand1
Copy link
Member

Summary

Only log these selectors if they are set to something

Checklist

  • No AI generated code was used in this PR

Related issues

resolves #16215

@DStrand1 DStrand1 self-assigned this Nov 25, 2024
@telegraf-tiger telegraf-tiger bot added area/prometheus chore plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins labels Nov 25, 2024
@DStrand1 DStrand1 assigned srebhan and unassigned DStrand1 Dec 6, 2024
@DStrand1 DStrand1 added the ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. label Dec 6, 2024
srebhan
srebhan reviewed Dec 9, 2024
View reviewed changes
Copy link
Member

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @DStrand1! Just one question...

plugins/inputs/prometheus/prometheus.go Outdated Show resolved Hide resolved
srebhan
srebhan approved these changes Dec 9, 2024
View reviewed changes
Copy link
Member

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @DStrand1!

@srebhan srebhan merged commit e713360 into influxdata:master Dec 9, 2024
5 of 12 checks passed
@github-actions github-actions bot added this to the v1.33.0 milestone Dec 9, 2024
@telegraf-tiger
Copy link
Contributor

telegraf-tiger bot commented Dec 9, 2024

Download PR build artifacts for linux_amd64.tar.gz, darwin_arm64.tar.gz, and windows_amd64.zip.
Downloads for additional architectures and packages are available below.

🥳 This pull request decreases the Telegraf binary size by -4.56 % for linux amd64 (new size: 256.5 MB, nightly size 268.7 MB)

📦 Click here to get additional PR build artifacts

Artifact URLs

DEB RPM TAR GZ ZIP
amd64.deb aarch64.rpm darwin_amd64.tar.gz windows_amd64.zip
arm64.deb armel.rpm darwin_arm64.tar.gz windows_arm64.zip
armel.deb armv6hl.rpm freebsd_amd64.tar.gz windows_i386.zip
armhf.deb i386.rpm freebsd_armv7.tar.gz
i386.deb ppc64le.rpm freebsd_i386.tar.gz
mips.deb riscv64.rpm linux_amd64.tar.gz
mipsel.deb s390x.rpm linux_arm64.tar.gz
ppc64el.deb x86_64.rpm linux_armel.tar.gz
riscv64.deb linux_armhf.tar.gz
s390x.deb linux_i386.tar.gz
linux_mips.tar.gz
linux_mipsel.tar.gz
linux_ppc64le.tar.gz
linux_riscv64.tar.gz
linux_s390x.tar.gz

justinwwhuang pushed a commit to justinwwhuang/telegraf_fork that referenced this pull request Dec 19, 2024
@DStrand1 @justinwwhuang
chore(inputs.prometheus): Improve label and field selector logging (i…
bd06760 
…nfluxdata#16228)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srebhan srebhan srebhan approved these changes

Assignees

@srebhan srebhan

Labels
area/prometheus chore plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review.
Projects
None yet
Milestone
v1.33.0
Development

Successfully merging this pull request may close these issues.

[inputs.prometheus] reduce logging verbosity
2 participants
@DStrand1 @srebhan