Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(inputs): Remove deprecated options from sample config #15872

Merged

Conversation

Hipska
Copy link
Contributor

@Hipska Hipska commented Sep 12, 2024

Summary

Remove deprecated options from the sample config as they might be confusing and also cleanup some code to not use these options.

Checklist

  • No AI generated code was used in this PR

Related issues

@telegraf-tiger telegraf-tiger bot added the chore label Sep 12, 2024
@Hipska Hipska marked this pull request as ready for review September 12, 2024 12:15
Copy link
Member

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much @Hipska for taking the effort cleaning up the configs! I do have some comments/questions in the code...

plugins/inputs/consul/consul.go Outdated Show resolved Hide resolved
plugins/inputs/consul/consul.go Outdated Show resolved Hide resolved
plugins/inputs/kube_inventory/README.md Show resolved Hide resolved
plugins/inputs/modbus/configuration_register.go Outdated Show resolved Hide resolved
plugins/inputs/sqlserver/README.md Show resolved Hide resolved
plugins/inputs/sqlserver/README.md Show resolved Hide resolved
@srebhan srebhan self-assigned this Sep 16, 2024
@srebhan srebhan added plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins area/configuration labels Sep 16, 2024
@telegraf-tiger
Copy link
Contributor

Copy link
Member

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Hipska!

@srebhan srebhan added the ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. label Sep 19, 2024
@srebhan srebhan assigned DStrand1 and unassigned srebhan Sep 19, 2024
@DStrand1 DStrand1 merged commit 0febb7e into influxdata:master Sep 23, 2024
27 checks passed
@github-actions github-actions bot added this to the v1.32.1 milestone Sep 23, 2024
@Hipska Hipska deleted the chore/inputs/deprecated_sample_config branch September 24, 2024 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/configuration chore plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants