Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(inputs.postgresql_extensible): Use same timestamp for each gather #15401

Merged
merged 1 commit into from
May 31, 2024

Conversation

powersj
Copy link
Contributor

@powersj powersj commented May 24, 2024

Summary

Rather than using a different timestamp for each query, this uses a single timestamp determined at the start of gather, for any and all metrics generated during that gather.

While the timestamp might be off from when the actual queries are run, it combines all metrics around a single timestamp to better understand when data was captured.

Checklist

  • No AI generated code was used in this PR

Related issues

fixes: #9737

Rather than using a different timestamp for each query, this uses a
single timestamp determined at the start of gather, for any and all
metrics generated during that gather.

While the timestamp might be off from when the actual queries are run,
it combines all metrics around a single timestamp to better understand
when data was captured.

fixes: influxdata#9737
@telegraf-tiger telegraf-tiger bot added fix pr to fix corresponding bug plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins labels May 24, 2024
@telegraf-tiger
Copy link
Contributor

@powersj powersj marked this pull request as ready for review May 24, 2024 19:57
@DStrand1 DStrand1 removed their assignment May 29, 2024
@powersj powersj added the ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. label May 29, 2024
Copy link
Member

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @powersj!

@srebhan srebhan merged commit 898b1c3 into influxdata:master May 31, 2024
27 checks passed
@github-actions github-actions bot added this to the v1.31.0 milestone May 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix pr to fix corresponding bug plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

postgresql_extensible wrong timestamp
3 participants