Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(aggregators.final): Add option to disable appending _final #15268

Merged
merged 2 commits into from
May 2, 2024

Conversation

LarsStegman
Copy link
Contributor

Summary

Changing the data schema is not always wanted. Especially when originals are dropped or the final value needs to be routed to a different output.

Checklist

  • No AI generated code was used in this PR

Related issues

resolves #15267

@telegraf-tiger telegraf-tiger bot added feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin plugin/aggregator 1. Request for new aggregator plugins 2. Issues/PRs that are related to aggregator plugins labels Apr 30, 2024
Copy link
Member

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just one suggestion...

plugins/aggregators/final/README.md Outdated Show resolved Hide resolved
Copy link
Member

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome. Thanks @LarsStegman!

@srebhan srebhan added the ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. label Apr 30, 2024
@LarsStegman
Copy link
Contributor Author

@srebhan @powersj @DStrand1 I have to compliment you on the way you maintain this repository and how responsive you are to issues and pull requests. Top notch stuff, people!

Copy link
Contributor

@powersj powersj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@srebhan @powersj @DStrand1 I have to compliment you on the way you maintain this repository and how responsive you are to issues and pull requests. Top notch stuff, people!

Thank you for the kind words!

@powersj powersj removed their assignment Apr 30, 2024
@DStrand1 DStrand1 merged commit d3f0ba9 into influxdata:master May 2, 2024
27 checks passed
@github-actions github-actions bot added this to the v1.31.0 milestone May 2, 2024
@LarsStegman LarsStegman deleted the feat/final-no-rename branch May 3, 2024 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin plugin/aggregator 1. Request for new aggregator plugins 2. Issues/PRs that are related to aggregator plugins ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat(aggregators.final): Add new tag instead of appending "_final" to fields
4 participants