Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(inputs.prometheus): Correctly handle host header #15195

Merged
merged 1 commit into from
Apr 19, 2024

Conversation

powersj
Copy link
Contributor

@powersj powersj commented Apr 19, 2024

Summary

Host header needs to be treated differently, via the Host value. Previously had to do this with influxdb in #14481

Checklist

  • No AI generated code was used in this PR

Related issues

fixes: #15192

@telegraf-tiger telegraf-tiger bot added area/prometheus fix pr to fix corresponding bug plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins labels Apr 19, 2024
@powersj powersj self-assigned this Apr 19, 2024
@telegraf-tiger
Copy link
Contributor

@powersj powersj added the ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. label Apr 19, 2024
@powersj powersj assigned srebhan and DStrand1 and unassigned powersj Apr 19, 2024
Copy link
Member

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @powersj!

@srebhan srebhan removed their assignment Apr 19, 2024
@DStrand1 DStrand1 merged commit 6bb3d32 into influxdata:master Apr 19, 2024
26 checks passed
@github-actions github-actions bot added this to the v1.30.2 milestone Apr 19, 2024
powersj added a commit that referenced this pull request Apr 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/prometheus fix pr to fix corresponding bug plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

inputs.prometheus - http_headers - host header ignored
3 participants