Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(inputs.diskio): Add missing udev properties #15003

Merged
merged 4 commits into from
Mar 18, 2024

Conversation

srebhan
Copy link
Member

@srebhan srebhan commented Mar 15, 2024

Summary

Add the missing DEVPATH, DEVNAME and DEVTYPE properties. In the course also fix the sample.conf to represent the default values.

Checklist

  • No AI generated code was used in this PR

Related issues

resolves #3663

@telegraf-tiger telegraf-tiger bot added fix pr to fix corresponding bug plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins labels Mar 15, 2024
@telegraf-tiger
Copy link
Contributor

@srebhan srebhan added the ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. label Mar 18, 2024
@srebhan srebhan assigned DStrand1 and powersj and unassigned srebhan Mar 18, 2024
Copy link
Contributor

@powersj powersj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, one question about the readme.

plugins/inputs/diskio/README.md Show resolved Hide resolved
@powersj powersj removed their assignment Mar 18, 2024
@DStrand1 DStrand1 merged commit c9fb4e7 into influxdata:master Mar 18, 2024
26 checks passed
@github-actions github-actions bot added this to the v1.30.1 milestone Mar 18, 2024
@Daryes
Copy link

Daryes commented Mar 20, 2024

Sorry to chime in a little late, but unless I am mistaken, the default value for skip_serial_number in the code is : false.
The updated documentation currently states the default is : true

@powersj
Copy link
Contributor

powersj commented Mar 21, 2024

@Daryes,

While booleans default to false, when we initialize the plugin it defaults to true:

https://github.com/influxdata/telegraf/blob/master/plugins/inputs/diskio/diskio.go#L192

Let me know if you are seeing otherwise.

@Daryes
Copy link

Daryes commented Mar 21, 2024

I didn't see the init bloc while searching in the code.
Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix pr to fix corresponding bug plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Expected udev properties cannot be used in diskio input
4 participants