Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(inputs.gnmi): Handle canonical field-name correctly #14953

Merged
merged 1 commit into from
Mar 8, 2024

Conversation

srebhan
Copy link
Member

@srebhan srebhan commented Mar 7, 2024

Summary

PR #14553 fixed path handling for field names. In this course the canonical-field-name handling was overlooked because now the path is no longer a simple string leading to

2024-03-07T12:44:38Z E! [inputs.gnmi] Invalid empty path "/system/memory/state/reserved" with alias "/system/memory/state"
2024-03-07T12:44:38Z E! [inputs.gnmi] Invalid empty path "/system/memory/state/used" with alias "/system/memory/state"

errors (see #14946). This PR fixes the issue and restores the previous functionality.

Checklist

  • No AI generated code was used in this PR

Related issues

related to #14946

@telegraf-tiger telegraf-tiger bot added area/gnmi fix pr to fix corresponding bug plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins labels Mar 7, 2024
@srebhan srebhan added the ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. label Mar 7, 2024
@DStrand1 DStrand1 removed their assignment Mar 8, 2024
@powersj powersj merged commit 8218651 into influxdata:master Mar 8, 2024
26 checks passed
@github-actions github-actions bot added this to the v1.30.0 milestone Mar 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/gnmi fix pr to fix corresponding bug plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants