Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(parser.prometheusremotewrite): Parse and generate histogram buckets #14952

Merged
merged 6 commits into from
Mar 13, 2024
Merged

feat(parser.prometheusremotewrite): Parse and generate histogram buckets #14952

merged 6 commits into from
Mar 13, 2024

Conversation

powersj
Copy link
Contributor

@powersj powersj commented Mar 7, 2024 •
edited
Loading

Summary

Enable the parsing of histograms that we are currently entirely ignoring in prometheus remote write plugin.

Checklist

  • No AI generated code was used in this PR

Related issues

resolves #14890

@powersj powersj mentioned this pull request Mar 7, 2024
Closed
@powersj powersj changed the title Fix/14890 feat(parser.prometheusremotewrite): Parse and generate histogram buckets Mar 7, 2024
@telegraf-tiger telegraf-tiger bot added feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin plugin/parser 1. Request for new parser plugins 2. Issues/PRs that are related to parser plugins labels Mar 7, 2024
@powersj powersj self-assigned this Mar 7, 2024
@powersj powersj added the ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. label Mar 11, 2024
@powersj powersj assigned srebhan and DStrand1 and unassigned powersj Mar 11, 2024
@powersj powersj marked this pull request as ready for review March 11, 2024 22:30
@srebhan
Copy link
Member

srebhan commented Mar 12, 2024

@powersj is your "Do not merge" tag in the description still valid?

srebhan
srebhan reviewed Mar 12, 2024
View reviewed changes
Copy link
Member

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I would only directly initialize the fields...

plugins/parsers/prometheusremotewrite/parser.go Outdated Show resolved Hide resolved
plugins/parsers/prometheusremotewrite/parser.go Outdated Show resolved Hide resolved
plugins/parsers/prometheusremotewrite/parser.go Outdated Show resolved Hide resolved
@powersj
Copy link
Contributor Author

powersj commented Mar 12, 2024

@powersj is your "Do not merge" tag in the description still valid?

It wasn't, but the user came back with a comment, so now I need to go look into something. I'll remove the waiting for final review tag.

@powersj powersj removed the ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. label Mar 12, 2024
@powersj powersj assigned powersj and unassigned srebhan and DStrand1 Mar 12, 2024
@powersj powersj added the ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. label Mar 12, 2024
@powersj powersj assigned srebhan and DStrand1 and unassigned powersj Mar 12, 2024
@powersj
Copy link
Contributor Author

powersj commented Mar 12, 2024 •
edited
Loading

ok updated histograms, rebased on master. Ready for review.

@telegraf-tiger
Copy link
Contributor

Download PR build artifacts for linux_amd64.tar.gz, darwin_arm64.tar.gz, and windows_amd64.zip.
Downloads for additional architectures and packages are available below.

⚠️ This pull request increases the Telegraf binary size by 2.97 % for linux amd64 (new size: 231.4 MB, nightly size 224.7 MB)

📦 Click here to get additional PR build artifacts

Artifact URLs

DEB RPM TAR GZ ZIP
amd64.deb aarch64.rpm darwin_amd64.tar.gz windows_amd64.zip
arm64.deb armel.rpm darwin_arm64.tar.gz windows_arm64.zip
armel.deb armv6hl.rpm freebsd_amd64.tar.gz windows_i386.zip
armhf.deb i386.rpm freebsd_armv7.tar.gz
i386.deb ppc64le.rpm freebsd_i386.tar.gz
mips.deb riscv64.rpm linux_amd64.tar.gz
mipsel.deb s390x.rpm linux_arm64.tar.gz
ppc64el.deb x86_64.rpm linux_armel.tar.gz
riscv64.deb linux_armhf.tar.gz
s390x.deb linux_i386.tar.gz
linux_mips.tar.gz
linux_mipsel.tar.gz
linux_ppc64le.tar.gz
linux_riscv64.tar.gz
linux_s390x.tar.gz

srebhan
srebhan approved these changes Mar 13, 2024
View reviewed changes
Copy link
Member

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @powersj!

@srebhan srebhan removed their assignment Mar 13, 2024
@DStrand1 DStrand1 merged commit 8bd837e into influxdata:master Mar 13, 2024
26 checks passed
@github-actions github-actions bot added this to the v1.31.0 milestone Mar 13, 2024
@BrewTestBot BrewTestBot mentioned this pull request Jun 10, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srebhan srebhan srebhan approved these changes

@DStrand1 DStrand1 DStrand1 approved these changes

Assignees

@DStrand1 DStrand1

Labels
feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin plugin/parser 1. Request for new parser plugins 2. Issues/PRs that are related to parser plugins ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review.
Projects
None yet
Milestone
v1.31.0
Development

Successfully merging this pull request may close these issues.

Missing histogram measurements in Prometheus Remote Write Spec
3 participants
@powersj @srebhan @DStrand1