Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(inputs.netflow): Fallback to IPFIX mappings for Netflow v9 #14910

Merged
merged 1 commit into from
Mar 4, 2024

Conversation

srebhan
Copy link
Member

@srebhan srebhan commented Feb 28, 2024

Summary

Some devices send IPFIX elements encapsulated in Netflow v9 packets. As a workaround, this PR falls back to IPFIX mappings if none of the Netflow v9 or user mappings worked.

Checklist

  • No AI generated code was used in this PR

Related issues

resolves #14902
resolves #14903

@telegraf-tiger telegraf-tiger bot added fix pr to fix corresponding bug plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins labels Feb 28, 2024
@telegraf-tiger
Copy link
Contributor

Download PR build artifacts for linux_amd64.tar.gz, darwin_arm64.tar.gz, and windows_amd64.zip.
Downloads for additional architectures and packages are available below.

⚠️ This pull request increases the Telegraf binary size by 1.32 % for linux amd64 (new size: 227.6 MB, nightly size 224.6 MB)

📦 Click here to get additional PR build artifacts

Artifact URLs

DEB RPM TAR GZ ZIP
amd64.deb aarch64.rpm darwin_amd64.tar.gz windows_amd64.zip
arm64.deb armel.rpm darwin_arm64.tar.gz windows_arm64.zip
armel.deb armv6hl.rpm freebsd_amd64.tar.gz windows_i386.zip
armhf.deb i386.rpm freebsd_armv7.tar.gz
i386.deb ppc64le.rpm freebsd_i386.tar.gz
mips.deb riscv64.rpm linux_amd64.tar.gz
mipsel.deb s390x.rpm linux_arm64.tar.gz
ppc64el.deb x86_64.rpm linux_armel.tar.gz
riscv64.deb linux_armhf.tar.gz
s390x.deb linux_i386.tar.gz
linux_mips.tar.gz
linux_mipsel.tar.gz
linux_ppc64le.tar.gz
linux_riscv64.tar.gz
linux_s390x.tar.gz

@srebhan srebhan added the ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. label Mar 1, 2024
@srebhan srebhan assigned powersj and DStrand1 and unassigned srebhan Mar 1, 2024
@powersj powersj removed their assignment Mar 1, 2024
@b0ch3nski
Copy link

@srebhan could you also bump github.com/netsampler/goflow2? Quite a lot of fixes done upstream.

@srebhan
Copy link
Member Author

srebhan commented Mar 4, 2024

@b0ch3nski please checkout #14923! Let me know there if the bumped version works as expected!

@DStrand1 DStrand1 merged commit 563eae9 into influxdata:master Mar 4, 2024
26 checks passed
@github-actions github-actions bot added this to the v1.30.0 milestone Mar 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix pr to fix corresponding bug plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review.
Projects
None yet
4 participants