Hugepages input plugin #1447
Closed
Hugepages input plugin #1447
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
A plugin that is described in #1176 |
| ) | ||
|
|
||
| var hugepagesSampleConfig = ` | ||
| ## |
There was a problem hiding this comment.
remove this line and 2-space indentation please :)
|
looks good, thanks @maksadbek, just the config formatting fix and I'll merge |
|
Ok, thanks |
| for k, v := range numaNodeMetrics { | ||
| metrics := make(map[string]interface{}) | ||
| tags := map[string]string{ | ||
| "node": k, |
There was a problem hiding this comment.
what's the possible size of the number of unique occurences of "k"? (ie, is there a cardinality concern here?)
There was a problem hiding this comment.
Theoretically one might have up to 1023 (max number of NUMA nodes in Linux kernels these days). In the real world it will probably always be well under 10.
|
@maksadbek what's the status of this PR? if you rebase your changes it should clear up the test failure |
|
closing for inactivity, please feel free to open a new PR when it's ready |
russorat
pushed a commit
that referenced
this pull request
Feb 8, 2018
russorat
pushed a commit
that referenced
this pull request
Jun 1, 2021
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Required for all PRs: