-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(processors.snmp_lookup): New SNMP lookup processor #14223
feat(processors.snmp_lookup): New SNMP lookup processor #14223
Conversation
…nmp_lookup * upstream/master: chore(linters): Fix findings found by testifylint: expected-actual (influxdata#14229) chore(deps): Bump github.com/nats-io/nkeys from 0.4.5 to 0.4.6 (influxdata#14225) feat(inputs.procstat)!: Remove useless zero cpu_times (influxdata#14224) feat(inputs.gnmi): Rework plugin (influxdata#14091) fix(outputs.timestream): Clip uint64 values (influxdata#14213) fix(inputs.cgroup): Escape backslashes (influxdata#14187) test(outputs.kafka): Use private network for testing (influxdata#14220) test(inputs.vault): Fix integration test by only testing for subset (influxdata#14222) fix(outputs.elasticsearch): Print error status value (influxdata#14115)
f4d43f0
to
4df6fee
Compare
* master: fix(inputs.win_perf_counter): Do not rely on returned buffer size (influxdata#14241) feat(inputs.modbus): Add support for string-fields (influxdata#14145) chore(deps): Bump cloud.google.com/go/storage from 1.30.1 to 1.34.1 (influxdata#14253) chore(deps): Bump github.com/rabbitmq/amqp091-go from 1.8.1 to 1.9.0 (influxdata#14252) chore(deps): Bump github.com/hashicorp/consul/api from 1.25.1 to 1.26.1 (influxdata#14251) chore(deps): Bump github.com/aws/aws-sdk-go-v2/service/cloudwatchlogs from 1.23.5 to 1.26.0 (influxdata#14249) fix(config): Fix comment removal in TOML files (influxdata#14240) feat(outputs.prometheus_client): Support listen on vsock (influxdata#14108) fix(inputs.mqtt_consumer): Resolve could not mark message delivered (influxdata#14243) chore(linters): Fix findings found by testifylint for Windows and enable it. (influxdata#14238) feat(migrations): Add option migration for inputs.nats_consumer (influxdata#14234) feat(migrations): Add option migration for inputs.mqtt_consumer (influxdata#14233) test(inputs.jolokia2_agent): Sort metrics as order is not consistent (influxdata#14227)
5da46b7
to
2e0ed1a
Compare
My understanding is the next step was the refactoring PR you recently put up. We can take a look shortly. |
(not stored in a cache)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good @Hipska. Please move the deprecation of ifname
to another PR together with a proper migration and leave it out here.
This reverts commit a8ce6a4.
Done, moved deprecation to #14899. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @Hipska!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @Hipska! Just one small thing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm +1 once Dane's suggestion lands.
Co-authored-by: Dane Strandboge <136023093+DStrand1@users.noreply.github.com>
Download PR build artifacts for linux_amd64.tar.gz, darwin_arm64.tar.gz, and windows_amd64.zip. 📦 Click here to get additional PR build artifactsArtifact URLs |
Required for all PRs
Add a new, more generic SNMP lookup processor compared to the ifname processor.