Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Outputs enhancement to require Description and SampleConfig functions #142

Closed
wants to merge 1 commit into from

Conversation

sparrc
Copy link
Contributor

@sparrc sparrc commented Aug 26, 2015

/cc @jipperinbham please verify the SampleConfg() and Description() functions for the datadog output, thanks!

@sparrc sparrc force-pushed the outputs-polish branch 3 times, most recently from 83082d9 to acc27f6 Compare August 26, 2015 00:06
# password = "metricsmetricsmetricsmetrics"
# Tags can also be specified via a normal map, but only one form at a time:
[tags]
# dc = "us-east-1" }
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that closing bracket } is out of place/not needed

@jipperinbham
Copy link
Contributor

@sparrc couple comments but nothing ground breaking :)

thanks for adding this!

@sparrc sparrc force-pushed the outputs-polish branch 2 times, most recently from 1046612 to 8afbad9 Compare August 26, 2015 04:22
@sparrc sparrc closed this in a00510a Aug 26, 2015
@sparrc
Copy link
Contributor Author

sparrc commented Aug 26, 2015

thanks @jipperinbham for the feedback 👍

@sparrc sparrc deleted the outputs-polish branch August 26, 2015 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants