Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Made the apache input’s urls parameter optional by using a reasonable default user input #1288

Merged
merged 1 commit into from
May 27, 2016

Conversation

martinseener
Copy link
Contributor

  • [x ] Sign CLA (if not already signed)

Why? Since most users will run this plugin on the destination host, the default http://localhost/server-status?auto is just fine and will be the default if urls is not defined simplifying the telegraf configuration for those users. They just need to add [[inputs.apache]] to be done.

@@ -20,7 +20,7 @@ type Apache struct {
}

var sampleConfig = `
## An array of Apache status URI to gather stats.
## An array of Apache status URI to gather stats. Default is "http://localhost/server-status?auto".
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please limit lines to 80 chars

@martinseener
Copy link
Contributor Author

Made the change and rebased it, please review @sparrc

@sparrc
Copy link
Contributor

sparrc commented May 27, 2016

thx

@sparrc sparrc merged commit 984b6cb into influxdata:master May 27, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants