Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: allow 201 for cookies, update header docs #11472

Merged
merged 1 commit into from
Jul 8, 2022
Merged

fix: allow 201 for cookies, update header docs #11472

merged 1 commit into from
Jul 8, 2022

Conversation

powersj
Copy link
Contributor

@powersj powersj commented Jul 7, 2022

This allows both a 200 and 201 response code when generating auth using
the cookie auth plugin. Additionally, this updates the docs for the
cookie headers to show a TOML map rather than a string.

fixes: #11134

@powersj
fix: allow 201 for cookies, update header docs
e945364 
This allows both a 200 and 201 response code when generating auth using
the cookie auth plugin. Additionally, this updates the docs for the
cookie headers to show a TOML map rather than a string.

fixes: influxdata#11134
@telegraf-tiger telegraf-tiger bot added the fix pr to fix corresponding bug label Jul 7, 2022
@powersj powersj mentioned this pull request Jul 7, 2022
Closed
@telegraf-tiger
Copy link
Contributor

telegraf-tiger bot commented Jul 7, 2022

Download PR build artifacts for linux_amd64.tar.gz, darwin_amd64.tar.gz, and windows_amd64.zip.
Downloads for additional architectures and packages are available below.

☺️ This pull request doesn't significantly change the Telegraf binary size (less than 1%)

📦 Click here to get additional PR build artifacts

Artifact URLs

DEB RPM TAR GZ ZIP
amd64.deb aarch64.rpm darwin_amd64.tar.gz windows_amd64.zip
arm64.deb armel.rpm darwin_arm64.tar.gz windows_i386.zip
armel.deb armv6hl.rpm freebsd_amd64.tar.gz
armhf.deb i386.rpm freebsd_armv7.tar.gz
i386.deb ppc64le.rpm freebsd_i386.tar.gz
mips.deb riscv64.rpm linux_amd64.tar.gz
mipsel.deb s390x.rpm linux_arm64.tar.gz
ppc64el.deb x86_64.rpm linux_armel.tar.gz
riscv64.deb linux_armhf.tar.gz
s390x.deb linux_i386.tar.gz
linux_mips.tar.gz
linux_mipsel.tar.gz
linux_ppc64le.tar.gz
linux_riscv64.tar.gz
linux_s390x.tar.gz
static_linux_amd64.tar.gz

@SpiderD555 SpiderD555 mentioned this pull request Jul 8, 2022
Closed
srebhan
srebhan reviewed Jul 8, 2022
View reviewed changes
Copy link
Member

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix @powersj. Just two questions regarding the config change...

plugins/inputs/http/README.md Show resolved Hide resolved
plugins/inputs/http/sample.conf Show resolved Hide resolved
@srebhan srebhan self-assigned this Jul 8, 2022
srebhan
srebhan approved these changes Jul 8, 2022
View reviewed changes
Copy link
Member

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks @powersj!

@srebhan srebhan added the ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. label Jul 8, 2022
@powersj powersj merged commit 5084831 into influxdata:master Jul 8, 2022
@powersj powersj deleted the fix/11134 branch July 8, 2022 21:10
srebhan pushed a commit that referenced this pull request Jul 11, 2022
@powersj
fix: allow 201 for cookies, update header docs (#11472)
c429d69 
(cherry picked from commit 5084831)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srebhan srebhan srebhan approved these changes

Assignees

@srebhan srebhan

Labels
fix pr to fix corresponding bug ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

inputs.http cookie_auth_headers cannot unmarshal TOML string into map[string]string
2 participants
@powersj @srebhan