Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When sending Telegraf data to Graphite, many of the metrics generated by the
win_perf_counters
input plugin aren't properly sanitized, and get ignored by Carbon.For example, for the following config, only
Processes
andThreads
succeed:If run in debug mode, telegraf produces this output:
The metrics are received by carbon, but it throws these 4 errors:
I see that the Graphite output serializer sanitizes the bucket name, but it doesn't sanitize the field itself, and
win_perf_counters
doesn't do any kind of sanitizing when gathering metrics.