Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update starlark 7a1108eaa012->d1966c6b9fcd #10940

Merged
merged 3 commits into from
Apr 12, 2022
Merged

Conversation

sspaink
Copy link
Contributor

@sspaink sspaink commented Apr 5, 2022

resolve: #10828

Updating go.starlark.net to latest version, the project doesn't use official releases but we are using the latest commit. As suggested by @Hipska updated the spec as well to point to the commit instead of master.

@Hipska could you test out this change? thanks!

@telegraf-tiger telegraf-tiger bot added the fix pr to fix corresponding bug label Apr 5, 2022
Copy link
Contributor

@Hipska Hipska left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, only change the url for all references..

plugins/processors/starlark/README.md Outdated Show resolved Hide resolved
plugins/aggregators/starlark/README.md Outdated Show resolved Hide resolved
@Hipska Hipska added docs Issues related to Telegraf documentation and configuration descriptions dependencies Pull requests that update a dependency file ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. labels Apr 6, 2022
@telegraf-tiger
Copy link
Contributor

telegraf-tiger bot commented Apr 6, 2022

@powersj powersj merged commit b139ee7 into master Apr 12, 2022
@powersj powersj deleted the updatestarlark branch April 12, 2022 13:54
sspaink added a commit that referenced this pull request Apr 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file docs Issues related to Telegraf documentation and configuration descriptions fix pr to fix corresponding bug ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Starlark spec
3 participants