Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: new input Hugepages plugin #10763

Merged
merged 16 commits into from
Mar 16, 2022
Merged

feat: new input Hugepages plugin #10763

merged 16 commits into from
Mar 16, 2022

Conversation

zak-pawel
Copy link
Collaborator

Former PRs: #1447 & #3775
Resolves: #1176

Adds Hugepage input plugin which gathers huge pages measurements.
Consult https://www.kernel.org/doc/html/latest/admin-guide/mm/hugetlbpage.html for more details.

@telegraf-tiger telegraf-tiger bot added the feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin label Mar 2, 2022
@zak-pawel zak-pawel requested a review from srebhan March 2, 2022 22:25
plugins/inputs/hugepages/README.md Outdated Show resolved Hide resolved
plugins/inputs/hugepages/hugepages.go Show resolved Hide resolved
Copy link
Member

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work @zak-pawel! I have some comments, nothing too big though... Can you please take a look?!

plugins/inputs/hugepages/hugepages.go Outdated Show resolved Hide resolved
plugins/inputs/hugepages/hugepages.go Outdated Show resolved Hide resolved
plugins/inputs/hugepages/hugepages.go Outdated Show resolved Hide resolved
plugins/inputs/hugepages/hugepages.go Outdated Show resolved Hide resolved
plugins/inputs/hugepages/hugepages.go Outdated Show resolved Hide resolved
plugins/inputs/hugepages/hugepages.go Outdated Show resolved Hide resolved
plugins/inputs/hugepages/hugepages_test.go Show resolved Hide resolved
plugins/inputs/hugepages/hugepages_test.go Outdated Show resolved Hide resolved
@srebhan srebhan self-assigned this Mar 4, 2022
@srebhan srebhan added area/system plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins labels Mar 4, 2022
@zak-pawel zak-pawel requested a review from srebhan March 6, 2022 19:53
@reimda reimda added the ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. label Mar 8, 2022
Copy link
Contributor

@Hipska Hipska left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Some minor remarks..

plugins/inputs/hugepages/README.md Outdated Show resolved Hide resolved
plugins/inputs/hugepages/hugepages.go Show resolved Hide resolved
Copy link
Member

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have some comments, but it's only cosmetics.

plugins/inputs/hugepages/hugepages.go Outdated Show resolved Hide resolved
plugins/inputs/hugepages/hugepages.go Outdated Show resolved Hide resolved
Copy link
Member

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect thanks!

Copy link
Contributor

@reimda reimda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you think about shortening the names of the hugepages_meminfo metric?

plugins/inputs/hugepages/hugepages.go Outdated Show resolved Hide resolved
@zak-pawel zak-pawel requested a review from reimda March 16, 2022 08:45
Copy link
Contributor

@reimda reimda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Pawel!

@reimda reimda merged commit 7e652fd into influxdata:master Mar 16, 2022
MyaLongmire pushed a commit that referenced this pull request Jul 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/system feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[RFC] Optionally collect huge page metrics, including per NUMA node, in "mem" plugin
4 participants