Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: openweathermap add feels_like field #10705

Merged
merged 3 commits into from
Feb 22, 2022
Merged

fix: openweathermap add feels_like field #10705

merged 3 commits into from
Feb 22, 2022

Conversation

popey
Copy link
Contributor

@popey popey commented Feb 22, 2022

Required for all PRs:

resolves #10695

Added the necessary float data structure to hold the feels_like temperature data.
Updated the test case to include the data during tests.
Ran locally and updated the README.md to include the actual data from the API.

@telegraf-tiger telegraf-tiger bot added the fix pr to fix corresponding bug label Feb 22, 2022
@powersj
Copy link
Contributor

powersj commented Feb 22, 2022

Run make check and make lint-branch localy and resolve those issues and you should be good to go.

@popey
Copy link
Contributor Author

popey commented Feb 22, 2022

Thanks for the feedback. All good I think?

alan@robot:~/Source/influxdata/telegraf-issue-10695/telegraf$ make check
go vet $(go list ./... | grep -v ./plugins/parsers/influx)
alan@robot:~/Source/influxdata/telegraf-issue-10695/telegraf$ PATH=$PATH:/usr/local/bin:/home/alan/go/bin make lint-branch
golangci-lint run --new-from-rev master
alan@robot:~/Source/influxdata/telegraf-issue-10695/telegraf$ 

@telegraf-tiger
Copy link
Contributor

@powersj powersj added the ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. label Feb 22, 2022
@MyaLongmire MyaLongmire merged commit 9f9d3c9 into influxdata:master Feb 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix pr to fix corresponding bug ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Feels_Like temperature
3 participants