Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(outputs.groundwork): Set NextCheckTime to LastCheckTime #10623

Merged
merged 1 commit into from
Feb 22, 2022
Merged

fix(outputs.groundwork): Set NextCheckTime to LastCheckTime #10623

merged 1 commit into from
Feb 22, 2022

Conversation

Hipska
Copy link
Contributor

@Hipska Hipska commented Feb 10, 2022

To avoid GroundWork to invent a value like LastCheckTime + 5 minutes

Required for all PRs:

@telegraf-tiger telegraf-tiger bot added the fix pr to fix corresponding bug label Feb 10, 2022
@Hipska Hipska added the plugin/output 1. Request for new output plugins 2. Issues/PRs that are related to out plugins label Feb 10, 2022
@powersj
Copy link
Contributor

powersj commented Feb 15, 2022

@Hipska have you been able to test this fix? I'm only asking since the only reference to 5 minutes was from what appears to be an example config and not used.

@Hipska
Copy link
Contributor Author

Hipska commented Feb 18, 2022

It is something GroundWork does internally, so you won't see that in the used lib.

Preferred scenario would be the output plugin be able to know what the interval for the metrics's input plugin is, but since that is not available it seems better to have both timestamps the same.

@powersj powersj added the ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. label Feb 22, 2022
@MyaLongmire MyaLongmire merged commit 906c714 into influxdata:master Feb 22, 2022
@Hipska Hipska deleted the feature/gw-nextcheck branch March 22, 2022 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix pr to fix corresponding bug plugin/output 1. Request for new output plugins 2. Issues/PRs that are related to out plugins ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants