-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Fix missing disks in container #10318
Conversation
…ry to access the real host partition as newer gopsutil will check init's mountinfo which does not contain the prefix.
📦 Looks like new artifacts were built from this PR. Expand this list to get them here ! 🐯Artifact URLs |
(cherry picked from commit 7867ef3)
After this change, logs are plagued with this type of messages: 2022-01-19T19:40:03Z D! [inputs.disk] [SystemPS] partition 0: {"device":"sysfs","mountpoint":"/sys","fstype":"sysfs","opts":["rw","nosuid","nodev","noexec","relatime"]} |
@voiprodrigo as you can see those are debug messages. Is there any reason you are running in debug mode? |
@srebhan I know they're debug. Still, I feel these look as "debug during development/bug fixing", not "debugging in production". Mostly because of the buffer messages, I like to keep an eye on those. |
@voiprodrigo can you please open an issue to discuss possible solutions there? |
Required for all PRs:
resolves #10297
This PR fixes the missing disks when trying to run telegraf from within a container.