Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix missing disks in container #10318

Merged
merged 7 commits into from
Jan 5, 2022
Merged

Conversation

srebhan
Copy link
Member

@srebhan srebhan commented Dec 21, 2021

Required for all PRs:

resolves #10297

This PR fixes the missing disks when trying to run telegraf from within a container.

@srebhan srebhan changed the title fix:Fix missing disks in container fix: Fix missing disks in container Dec 21, 2021
@srebhan srebhan marked this pull request as ready for review December 22, 2021 12:05
@telegraf-tiger
Copy link
Contributor

@powersj powersj merged commit 7867ef3 into influxdata:master Jan 5, 2022
powersj pushed a commit that referenced this pull request Jan 5, 2022
@voiprodrigo
Copy link
Contributor

After this change, logs are plagued with this type of messages:

2022-01-19T19:40:03Z D! [inputs.disk] [SystemPS] partition 0: {"device":"sysfs","mountpoint":"/sys","fstype":"sysfs","opts":["rw","nosuid","nodev","noexec","relatime"]}
2022-01-19T19:40:03Z D! [inputs.disk] [SystemPS] -> using mountpoint "/sys"...
2022-01-19T19:40:03Z D! [inputs.disk] [SystemPS] => kept...
2022-01-19T19:40:03Z D! [inputs.disk] [SystemPS] partition 1: {"device":"proc","mountpoint":"/proc","fstype":"proc","opts":["rw","nosuid","nodev","noexec","relatime"]}
2022-01-19T19:40:03Z D! [inputs.disk] [SystemPS] => dropped by filesystem-type filter
2022-01-19T19:40:03Z D! [inputs.disk] [SystemPS] partition 2: {"device":"devtmpfs","mountpoint":"/dev","fstype":"devtmpfs","opts":["rw","nosuid"]}
2022-01-19T19:40:03Z D! [inputs.disk] [SystemPS] => dropped by filesystem-type filter

powersj pushed a commit to powersj/telegraf that referenced this pull request Jan 21, 2022
@srebhan
Copy link
Member Author

srebhan commented Jan 24, 2022

@voiprodrigo as you can see those are debug messages. Is there any reason you are running in debug mode?

@voiprodrigo
Copy link
Contributor

@srebhan I know they're debug. Still, I feel these look as "debug during development/bug fixing", not "debugging in production". Mostly because of the buffer messages, I like to keep an eye on those.

@srebhan
Copy link
Member Author

srebhan commented Jan 24, 2022

@voiprodrigo can you please open an issue to discuss possible solutions there?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Telegraf 1.21.1, input plugin disk doesn't report data for non-partitioned disks
3 participants