-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add option to disable Wavefront prefix conversion #10252
Merged
powersj
merged 2 commits into
influxdata:master
from
homedepot:serializer-wavefront-update
Dec 14, 2021
Merged
feat: Add option to disable Wavefront prefix conversion #10252
powersj
merged 2 commits into
influxdata:master
from
homedepot:serializer-wavefront-update
Dec 14, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Maintaining the default behavior for backwards compatibility, while adding the option of preserving original metric prefixes.
telegraf-tiger
bot
added
the
feat
Improvement on an existing feature such as adding a new setting/mode to an existing plugin
label
Dec 9, 2021
👍 This pull request doesn't change the Telegraf binary size 📦 Looks like new artifacts were built from this PR. Expand this list to get them here ! 🐯Artifact URLs |
bool-literal-in-expr: omit Boolean literal in expression (revive)
srebhan
approved these changes
Dec 9, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Thanks for your work @crflanigan and @zachmares!
srebhan
added
the
ready for final review
This pull request has been reviewed and/or tested by multiple users and is ready for a final review.
label
Dec 9, 2021
srebhan
added
area/wavefront
plugin/output
1. Request for new output plugins 2. Issues/PRs that are related to out plugins
labels
Dec 9, 2021
powersj
approved these changes
Dec 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area/wavefront
feat
Improvement on an existing feature such as adding a new setting/mode to an existing plugin
plugin/output
1. Request for new output plugins 2. Issues/PRs that are related to out plugins
ready for final review
This pull request has been reviewed and/or tested by multiple users and is ready for a final review.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Maintaining the default behavior for backwards compatibility, while adding the option of preserving original metric prefixes.
Required for all PRs:
resolves #7913
Users who use the Wavefront serializer who don't wish to have their metric prefixes modified may configure their output plugin in a similar way as the Wavefront Output Plugin.
Users may set the following configuration option:
wavefront_disable_prefix_conversion = true
Default behavior (enabled prefix/path conversion):
prod.prefix.name.metric.name
Configurable behavior (disabled prefix/path conversion):
prod.prefix_name.metric_name