Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add option to disable Wavefront prefix conversion #10252

Merged
merged 2 commits into from
Dec 14, 2021
Merged

feat: Add option to disable Wavefront prefix conversion #10252

merged 2 commits into from
Dec 14, 2021

Conversation

crflanigan
Copy link
Contributor

Maintaining the default behavior for backwards compatibility, while adding the option of preserving original metric prefixes.

Required for all PRs:

resolves #7913

Users who use the Wavefront serializer who don't wish to have their metric prefixes modified may configure their output plugin in a similar way as the Wavefront Output Plugin.

Users may set the following configuration option: wavefront_disable_prefix_conversion = true

Default behavior (enabled prefix/path conversion): prod.prefix.name.metric.name

Configurable behavior (disabled prefix/path conversion): prod.prefix_name.metric_name

Maintaining the default behavior for backwards compatibility, while adding the option of preserving original metric prefixes.
@telegraf-tiger telegraf-tiger bot added the feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin label Dec 9, 2021
@crflanigan
Copy link
Contributor Author

Note:
This PR is similar to #10210 and has been split as requested by @srebhan

@crflanigan
Copy link
Contributor Author

@zachmares

bool-literal-in-expr: omit Boolean literal in expression (revive)
Copy link
Member

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks for your work @crflanigan and @zachmares!

@srebhan srebhan added the ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. label Dec 9, 2021
@srebhan srebhan self-assigned this Dec 9, 2021
@srebhan srebhan added area/wavefront plugin/output 1. Request for new output plugins 2. Issues/PRs that are related to out plugins labels Dec 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/wavefront feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin plugin/output 1. Request for new output plugins 2. Issues/PRs that are related to out plugins ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Output plugin that supports sending metrics into Google CloudRun
4 participants