Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CloudWatch Metrics Input Plugin to Support Percentile Based Metrics #7951

Open
Josh-Bonello opened this issue Aug 6, 2020 · 6 comments
Open
Labels
area/aws AWS plugins including cloudwatch, ecs, kinesis cloud Issues or requests around cloud environments feature request Requests for new plugin and for new features to existing plugins help wanted Request for community participation, code, contribution size/m 2-4 day effort

Comments

@Josh-Bonello
Copy link
Contributor

Feature Request

Opening a feature request kicks off a discussion.

Proposal:

The CloudWatch GetMetricData API call has the capability to use an Expression to allow for gathering pXX.XX (IE p95) statistics metrics.

Current behavior:

Based on this function, only 'minimum, maximum, sum, samplecount, average' are supported metric values. There is no extendedmetrics available which would be used by extended metrics.

Desired behavior:

Allow for pXX.XX to be valid metrics to be gathered by the CloudWatch input plugin.

Use case:

For statistical analysis, it is often better to throw out outliers of a dataset to keep from distracting from underlying trends. Using p95 allows for a higher confidence interval in what real "max" usage is, p5 similarly for "minimum" usage, and p50 for "average" usage. This allows for a statistics_input object to contain arbitrary pXX.XX values and return them from the GetMetricData API. This is suggested as an additional option, rather than complete replacement, to allow for users of this plugin to choose which statistic set they prefer.

@sjwang90 sjwang90 added area/aws AWS plugins including cloudwatch, ecs, kinesis feature request Requests for new plugin and for new features to existing plugins labels Aug 11, 2020
@ssoroka
Copy link
Contributor

ssoroka commented Aug 19, 2020

Seems like the histogram format would be ideal for this.

@Josh-Bonello
Copy link
Contributor Author

@ssoroka Could you provide some more details about histogram format for a potential implementer, like myself?

@ssoroka
Copy link
Contributor

ssoroka commented Aug 19, 2020

Sure. Take a look at the aggregators.histogram plugin, as it outputs histograms and has examples of the outputted data format for pre-bucketed data.

I think you can also make a histogram out of pretty much any value and label combo.

@ssoroka ssoroka added the cloud Issues or requests around cloud environments label Oct 30, 2020
@reimda
Copy link
Contributor

reimda commented Sep 8, 2022

@Josh-Bonello are you still interested in this feature? #8894 asks for general expression support which I believe includes the pXX.XX expression you mention. When this is implemented we should probably aim to support more than just percentiles.

I realize it has been a long time since you made the request, but are you able to make the changes and submit a PR?

@reimda reimda added the waiting for response waiting for response from contributor label Sep 8, 2022
@Josh-Bonello
Copy link
Contributor Author

I believe this would be a real benefit to your users who consume cloudwatch. The histogram functionality that is mentioned previously by Steve requires the user to understand the boundaries of their bucket. CloudWatch data is vast and has many different values depending on their use case. I believe users to be better supported by using what is available in the source API.

They won't need to guess what values are around X percentile, the API will just provide what the Xth percentile is.

I can take a look at making changes, but it would be in "spare time" level of effort.

@telegraf-tiger telegraf-tiger bot removed the waiting for response waiting for response from contributor label Sep 8, 2022
@reimda reimda added help wanted Request for community participation, code, contribution size/m 2-4 day effort labels Sep 12, 2022
@reimda
Copy link
Contributor

reimda commented Sep 12, 2022

Thanks for responding even though this hasn't had any attention for a couple years.

I'm not aware of anyone else working on this. If you are able to take a look, even with "spare time" level of effort, it would be a help to the project. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/aws AWS plugins including cloudwatch, ecs, kinesis cloud Issues or requests around cloud environments feature request Requests for new plugin and for new features to existing plugins help wanted Request for community participation, code, contribution size/m 2-4 day effort
Projects
None yet
Development

No branches or pull requests

4 participants