Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Internal metrics have alias tag set to the empty string when unset #6541

Closed
danielnelson opened this issue Oct 18, 2019 · 2 comments · Fixed by #6571
Closed

Internal metrics have alias tag set to the empty string when unset #6541

danielnelson opened this issue Oct 18, 2019 · 2 comments · Fixed by #6571
Assignees
Labels
bug unexpected problem or unintended behavior
Milestone

Comments

@danielnelson
Copy link
Contributor

Relevant telegraf.conf:

[[inputs.internal]]

[[outputs.prometheus_client]]
  # ...

System info:

Telegraf 1.12.3

Steps to reproduce:

  1. Enable internal output and prometheus_client output
  2. Check metrics

Expected behavior:

Since no alias is set the tag shouldn't be added.

internal_gather_errors{input="internal",version="1.12.3"} 0

Actual behavior:

internal_gather_errors{alias="",input="internal",version="1.12.3"} 0

Additional info:

@danielnelson danielnelson added the bug unexpected problem or unintended behavior label Oct 18, 2019
@danielnelson danielnelson added this to the 1.12.4 milestone Oct 18, 2019
@sjwang90 sjwang90 added the ready label Oct 18, 2019
@TRSridhar
Copy link

Is this up for grabs? What does the ready label mean?

@danielnelson
Copy link
Contributor Author

danielnelson commented Oct 21, 2019

@TRSridhar Yes it is up for grabs, would you be able to take a look at it?

The ready label is an internal tag we are experimenting with for planning, its meaning and use will probably evolve a bit so I wouldn't pay it much attention.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug unexpected problem or unintended behavior
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants