Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[httpjson] add option to silence complaints about null values #3357

Closed
msoltyspl opened this issue Oct 18, 2017 · 3 comments · Fixed by #3359
Closed

[httpjson] add option to silence complaints about null values #3357

msoltyspl opened this issue Oct 18, 2017 · 3 comments · Fixed by #3359
Labels
bug unexpected problem or unintended behavior
Milestone

Comments

@msoltyspl
Copy link

Currently, whenever an explicit null value is encountered by httpjson - it always informs about it in the logs and there seems to be no way to turn it off, e.g.:

json parser ignoring pipelines_.monitoring-logstash_events
json parser ignoring pipelines_.monitoring-logstash_reloads_last_success_timestamp
json parser ignoring pipelines_.monitoring-logstash_reloads_last_failure_timestamp
json parser ignoring pipelines_.monitoring-logstash_reloads_last_error
json parser ignoring pipelines_.monitoring-logstash_queue
json parser ignoring pipelines_main_reloads_last_error
json parser ignoring pipelines_main_reloads_last_success_timestamp
json parser ignoring pipelines_main_reloads_last_failure_timestamp

So far I've been reloading (logstash) once with failed config and once with correct config to silence some of those messages, but that's a bit crude workaround. Explicit nulls are not technically invalid - so an option to just ignore those silently would be really welcome.

@danielnelson
Copy link
Contributor

I think we should just silence this without providing an option. Here is some JSON input that will trigger this message: {"x": null}

@danielnelson danielnelson added this to the 1.4.3 milestone Oct 18, 2017
@danielnelson danielnelson added the bug unexpected problem or unintended behavior label Oct 18, 2017
@msoltyspl
Copy link
Author

I think we should just silence this without providing an option. Here is some JSON input that will trigger this message: {"x": null}

Even better =)

@Fyyre
Copy link

Fyyre commented Oct 25, 2017

Michal, I apologize for writing this way - but I lost your contact. Long time since last speak. Can you please get in touch with me at fyyre @ fyyre.ru ?

Thanks =)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug unexpected problem or unintended behavior
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants