Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Aggregator is dropping metrics which are out of period. Whether drop or not should be configurable #2238

Closed
zhang8473 opened this issue Jan 7, 2017 · 2 comments

Comments

@zhang8473
Copy link

zhang8473 commented Jan 7, 2017

System info:

Telegraf 1.1.0

Feature Request

I wrote a telegraf aggregator to clean my Kafka data. However, some of the metrics are dropped mysteriously. After digging into the code, I found out that
https://github.com/influxdata/telegraf/blob/master/internal/models/running_aggregator.go#L152-L157

This part of codes filters them out. However, I need all data, including those out of period. Whether or drop the metrics out of period should be configurable.

Proposal:

Whether or drop the metrics out of period for aggregators should be configurable.

Current behavior:

drop.

Desired behavior:

I can config drop/not drop in telegraf.conf.

Use case: [Why is this important (helps with prioritizing requests)]

Use telegraf inside data pipeline. (not a sensor)

Some data always come later than the others. Thus the timestamp of that particular kind of data is always before the periodStart. That kind of data is always dropped, which is not supposed to be.

@zhang8473 zhang8473 changed the title Feature Request: Aggregator is dropping metrics which are out of period. This must be configurable Feature Request: Aggregator is dropping metrics which are out of period. Whether drop or not should be configurable Jan 7, 2017
@sparrc
Copy link
Contributor

sparrc commented Jan 9, 2017

dupe of #1992

@sparrc sparrc closed this as completed Jan 9, 2017
@xibz
Copy link

xibz commented Apr 27, 2018

edit: scratch that. It is a duplicate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants