Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker input plugin imagename/version split does not work if private registry with port in url is used #1987

Closed
erSitzt opened this issue Nov 3, 2016 · 4 comments
Labels
bug unexpected problem or unintended behavior
Milestone

Comments

@erSitzt
Copy link

erSitzt commented Nov 3, 2016

Bug report

The docker input plugin splits the image name and image version at the colon.

python:3

results in

container_image: python
container_version: 3

but the image name may contain a private registry url which contains a port, also with a colon for separation.

eg.

registry.domain.com:5000/monitoring/cadvisor:internal.0.23

This results in

container_image: registry.domain.com:
container_version: 5000/monitoring/cadvisor

System info:

Telegraf Docker image telegraf:alpine

@sparrc sparrc added the bug unexpected problem or unintended behavior label Nov 3, 2016
@sparrc sparrc added this to the 1.2.0 milestone Nov 3, 2016
@alex-sherwin
Copy link
Contributor

+1

2 similar comments
@sachagear
Copy link

+1

@deric
Copy link
Contributor

deric commented Nov 10, 2016

+1

@sparrc
Copy link
Contributor

sparrc commented Nov 10, 2016

this is already slated for a release and there is a PR up to fix it, there's no need to "+1", thanks

@sparrc sparrc closed this as completed in 3a45d88 Dec 16, 2016
njwhite pushed a commit to njwhite/telegraf that referenced this issue Jan 31, 2017
…luxdata#2018)

* fixed parsing of docker image name/version

now accounts for custom docker repo's which contain a colon for a non-default port

* 1978: modifying docker test case to have a custom repo with non-standard port

* using a temp var to store index, ran gofmt

* fixes influxdata#1987, renaming iterator to 'i'
maxunt pushed a commit that referenced this issue Jun 26, 2018
* fixed parsing of docker image name/version

now accounts for custom docker repo's which contain a colon for a non-default port

* 1978: modifying docker test case to have a custom repo with non-standard port

* using a temp var to store index, ran gofmt

* fixes #1987, renaming iterator to 'i'
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug unexpected problem or unintended behavior
Projects
None yet
Development

No branches or pull requests

5 participants