Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

persist starlark state for more starlark types #15924

Open
gazpachoking opened this issue Sep 22, 2024 · 0 comments
Open

persist starlark state for more starlark types #15924

gazpachoking opened this issue Sep 22, 2024 · 0 comments
Labels
feature request Requests for new plugin and for new features to existing plugins

Comments

@gazpachoking
Copy link
Contributor

Use Case

#15170 added the ability for the starlark processor to persist the global state to the statefile between runs. This is very nice, but it can't store lists, dicts, tuples, or metrics to the state file which severely limits its usefulness. If you try any more complex type you get an error like invalid starlark type *starlark.Metric when it tries to write the state file.

My desired use case is similar to the example for comparing a metric to the previous one. This doesn't work because it stores both a dict and a metric in the global state.

Expected behavior

Starlark standard types (lists, dicts, tuples, and maybe also metrics) can be persisted to the statefile.

Actual behavior

Error when persisting the plugin states.

Additional info

No response

@gazpachoking gazpachoking added the feature request Requests for new plugin and for new features to existing plugins label Sep 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request Requests for new plugin and for new features to existing plugins
Projects
None yet
Development

No branches or pull requests

1 participant