Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Outputs.Datadog does not support Distribution typed metrics #15576

Open
dirrao opened this issue Jun 28, 2024 · 2 comments
Open

Outputs.Datadog does not support Distribution typed metrics #15576

dirrao opened this issue Jun 28, 2024 · 2 comments
Labels
feature request Requests for new plugin and for new features to existing plugins

Comments

@dirrao
Copy link

dirrao commented Jun 28, 2024

Use Case

Looking for Datadog output plugin to support distribution metric type.

Expected behavior

Looking for Datadog output plugin to support distribution metric type.

Actual behavior

NA

Additional info

No response

@dirrao dirrao added the feature request Requests for new plugin and for new features to existing plugins label Jun 28, 2024
@dirrao
Copy link
Author

dirrao commented Jun 28, 2024

Recreating a new ticket for existing closed ticket #11525

@powersj
Copy link
Contributor

powersj commented Jun 28, 2024

Hi,

The current Datadog output seems to take an API URL as a parameter to send metrics only. By default it is set to https://app.datadoghq.com/api/v1/series, which is for submitting metrics only of type "", "count", "gauge", and "rate".

To send distributions, we need to use https://api.datadoghq.com/api/v1/distribution_points with type "distribution".

The plugin would need to be extended to:

  1. Add a new config option to set the distribution URL
  2. If that URL is set, then collect the metrics of type telegraf.Histogram
  3. After sending the metrics, then create a distribution request and send that using the options

This would be a change in behavior as the current as it does not look like we explicitly omit histograms today unless they error out during metric building?

Would be happy to see a PR to take this on, but need to ensure it is a) opt-in and b) tested and covered by unit tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request Requests for new plugin and for new features to existing plugins
Projects
None yet
Development

No branches or pull requests

2 participants