Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deployment status of testifylint checkers #15539

Closed
zak-pawel opened this issue Jun 20, 2024 · 6 comments
Closed

Deployment status of testifylint checkers #15539

zak-pawel opened this issue Jun 20, 2024 · 6 comments
Labels

Comments

@zak-pawel
Copy link
Collaborator

zak-pawel commented Jun 20, 2024

Current status:

Checker Issue To enable? PR(s) Work finished?
blank-import #15533 Y #15566 Y
bool-compare x Y #14163 #14238 Y
compares x Y #14177 #14238 Y
contains #16183
empty x Y #14179 #14238 Y
encoded-compare #16184
error-is-as x Y #14180 #14238 Y
error-nil x Y #14198 #14238 Y
expected-actual x Y #14229 #14238 Y
float-compare #15534 Y #15566 Y
formatter x Y #15797 Y
go-require #15535 Y #15727 #15887 #15985 #15991 #16076 #16098 #16158 Y
len x Y #14203 #14238 Y
negative-positive #15536 Y #15566 Y
nil-compare #15537 Y #15566 Y
regexp #16185
require-error x Y #14181 #14238 Y
suite-broken-parallel x Y #15797 Y
suite-dont-use-pkg x Y #14238 Y
suite-extra-assert-call x Y #14238 Y
suite-subtest-run x Y #15797 Y
suite-thelper x Y #14238 Y
useless-assert #15538 Y #15566 Y
@powersj
Copy link
Contributor

powersj commented Jun 25, 2024

next steps: wrap up new linter additions

@powersj
Copy link
Contributor

powersj commented Jul 16, 2024

@zak-pawel can we close this now that everything except #15535 has landed?

@powersj powersj added the waiting for response waiting for response from contributor label Jul 16, 2024
@zak-pawel
Copy link
Collaborator Author

@powersj Or we can wait until all the PRs are opened and merged ;)
The first one should be ready within a few days.

@telegraf-tiger telegraf-tiger bot removed the waiting for response waiting for response from contributor label Jul 16, 2024
@powersj
Copy link
Contributor

powersj commented Jul 16, 2024

What PRs are left? Based on the chart the only remaining rows do not have support in golangci-lint?

@powersj powersj added the waiting for response waiting for response from contributor label Jul 16, 2024
@zak-pawel
Copy link
Collaborator Author

@powersj go-require - 557 findings to address.

@telegraf-tiger telegraf-tiger bot removed the waiting for response waiting for response from contributor label Jul 16, 2024
@powersj
Copy link
Contributor

powersj commented Jul 16, 2024

That is tracked already by #15535, closing this.

@powersj powersj closed this as completed Jul 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants