Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redfish and Telegraf secrets #14682

Closed
Nikoos opened this issue Feb 5, 2024 · 4 comments · Fixed by #14702
Closed

Redfish and Telegraf secrets #14682

Nikoos opened this issue Feb 5, 2024 · 4 comments · Fixed by #14702
Assignees
Labels
feature request Requests for new plugin and for new features to existing plugins help wanted Request for community participation, code, contribution size/s 1 day effort, great beginniner issue

Comments

@Nikoos
Copy link

Nikoos commented Feb 5, 2024

Use Case

Hello team,

I will need to connect Supermicro IPMI with builtin Redfish compliant API to Telegraf in order to query power consumption, as for now, clear text login and passwords are only supported in the redfish plugin, adding support to telegraf secrets will add more security to this input plugin.

Regards,

Nikos

Expected behavior

Redfish input plugin should add support for the following configuration to enhance security :

[[inputs.redfish]]
  ## Redfish API Base URL.
  address = "https://ipmi-ipmi-xxxxxxxxxxxxxx"

  ## Credentials for the Redfish API.
  username = "@{telegraf:ipmi_username}"
  password = "@{telegraf:ipmi_password}"

Actual behavior

When using telegraf secrets, the following behavior can be seen in the log file :

E! [inputs.redfish] Error in plugin: received status code 401 (Unauthorized) for address https://ipmi-xxxxxxxxxxxxxx, expected 200

Additional info

Tested with the latest telegraf version available at the moment : 1.29.4 (git: HEAD@4441c4ed)

Regards,

Nikos

@Nikoos Nikoos added the feature request Requests for new plugin and for new features to existing plugins label Feb 5, 2024
@powersj powersj added help wanted Request for community participation, code, contribution size/s 1 day effort, great beginniner issue labels Feb 5, 2024
@powersj
Copy link
Contributor

powersj commented Feb 5, 2024

Thanks for the feature request.

@DStrand1 might be another good, short one for you!

@powersj
Copy link
Contributor

powersj commented Feb 8, 2024

@Nikoos - we've merged #14702 - it would still be good if you could download one of the artifacts from that PR and verify it works as expected. Thanks!

@Nikoos
Copy link
Author

Nikoos commented Feb 9, 2024

@powersj , sure will test in 5 minutes

@Nikoos
Copy link
Author

Nikoos commented Feb 9, 2024

Thanks for your quick add, it works perfectly.

Regards,

Nikos

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request Requests for new plugin and for new features to existing plugins help wanted Request for community participation, code, contribution size/s 1 day effort, great beginniner issue
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants