-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Telegraf win_perf_counters not sending input counters with % #1430
Labels
bug
unexpected problem or unintended behavior
Comments
sparrc
added a commit
that referenced
this issue
Jul 20, 2016
1. in prometheus client, do not check for invalid characters anymore, because we are already replacing all invalid characters with regex anyways. 2. in win_perf_counters, sanitize field name _and_ measurement name. Also add '%' to the list of sanitized characters, because this character is invalid for most output plugins, and can also easily cause string formatting issues throughout the stack. 3. All '%' will now be translated to 'Percent' closes #1430
1 task
thanks for the report, PR is up for fix: #1523 |
sparrc
added a commit
that referenced
this issue
Jul 20, 2016
1. in prometheus client, do not check for invalid characters anymore, because we are already replacing all invalid characters with regex anyways. 2. in win_perf_counters, sanitize field name _and_ measurement name. Also add '%' to the list of sanitized characters, because this character is invalid for most output plugins, and can also easily cause string formatting issues throughout the stack. 3. All '%' will now be translated to 'Percent' closes #1430
sparrc
added a commit
that referenced
this issue
Jul 20, 2016
1. in prometheus client, do not check for invalid characters anymore, because we are already replacing all invalid characters with regex anyways. 2. in win_perf_counters, sanitize field name _and_ measurement name. Also add '%' to the list of sanitized characters, because this character is invalid for most output plugins, and can also easily cause string formatting issues throughout the stack. 3. All '%' will now be translated to 'Percent' closes #1430
sparrc
added a commit
that referenced
this issue
Jul 21, 2016
1. in prometheus client, do not check for invalid characters anymore, because we are already replacing all invalid characters with regex anyways. 2. in win_perf_counters, sanitize field name _and_ measurement name. Also add '%' to the list of sanitized characters, because this character is invalid for most output plugins, and can also easily cause string formatting issues throughout the stack. 3. All '%' will now be translated to 'Percent' closes #1430
bitmori
pushed a commit
to bitmori/telegraf
that referenced
this issue
Jul 23, 2016
1. in prometheus client, do not check for invalid characters anymore, because we are already replacing all invalid characters with regex anyways. 2. in win_perf_counters, sanitize field name _and_ measurement name. Also add '%' to the list of sanitized characters, because this character is invalid for most output plugins, and can also easily cause string formatting issues throughout the stack. 3. All '%' will now be translated to 'Percent' closes influxdata#1430
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
It appears that Telegraf is not allowing metrics with % to send over to a listening Prometheus server. Any metric without a % works without issue.
telegraf.conf:
Log Info
System info:
Telegraf (version 1.0.0-beta2)
Windows 7 Professional Virtual Machine
Steps to reproduce:
Expected behavior:
Metrics with % should be showing up in Prometheus server
Actual behavior:
Metrics with % do not show up in Prometheus server
The text was updated successfully, but these errors were encountered: