Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Linter: gosec, Rule: G107 - Url provided to HTTP request as taint input. Should we enable it? #12894

Closed
zak-pawel opened this issue Mar 18, 2023 · 2 comments · Fixed by #13010
Labels

Comments

@zak-pawel
Copy link
Collaborator

Use Case

This issue starts discussion about enabling:

Rule is mapped to CWE-88: Improper Neutralization of Argument Delimiters in a Command ('Argument Injection')
.

Expected behavior

Decision if rule should be enabled or not.

Actual behavior

For this rule following finding was found in current code:

tools/license_checker/package.go:34:19  gosec  G107: Potential HTTP request made with variable url

Additional info

For this rule no additional configuration can be provided.

@zak-pawel zak-pawel added feature request Requests for new plugin and for new features to existing plugins needs design review labels Mar 18, 2023
@powersj
Copy link
Contributor

powersj commented Mar 21, 2023

+1

@zak-pawel zak-pawel added linter and removed feature request Requests for new plugin and for new features to existing plugins needs design review labels Mar 22, 2023
@zak-pawel
Copy link
Collaborator Author

More info: https://securego.io/docs/rules/g107.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants