Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SOCKS support for HTTP Response plugin #11804

Open
viliampucik opened this issue Sep 14, 2022 · 1 comment
Open

SOCKS support for HTTP Response plugin #11804

viliampucik opened this issue Sep 14, 2022 · 1 comment
Labels
feature request Requests for new plugin and for new features to existing plugins help wanted Request for community participation, code, contribution plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins size/s 1 day effort, great beginniner issue

Comments

@viliampucik
Copy link

Use Case

We would like to use HTTP Response plugin to measure web page latency, however the page is accessible via a SOCKS proxy. The plugin support HTTP proxy, but not SOCKS.

Expected behavior

HTTP Response plugin supports SOCKS configuration.

Actual behavior

HTTP Response plugin ignores SOCKS related settings, such as socks5_enabled, socks5_address, socks5_username, socks5_password.

Additional info

No response

@viliampucik viliampucik added the feature request Requests for new plugin and for new features to existing plugins label Sep 14, 2022
@Hipska Hipska added the plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins label Sep 19, 2022
@MyaLongmire MyaLongmire added size/s 1 day effort, great beginniner issue help wanted Request for community participation, code, contribution labels Sep 20, 2022
@reimda
Copy link
Contributor

reimda commented Sep 20, 2022

As far as I can tell, the http_response input only has support for http proxy. I think the only telegraf plugins that support socks are the websocket output and the kafka output.

Since telegraf does have some common code available to use, it may not be too difficult to add this to the http response input as a new feature. Would you be able to make the code changes using those output plugins as examples and submit a PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request Requests for new plugin and for new features to existing plugins help wanted Request for community participation, code, contribution plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins size/s 1 day effort, great beginniner issue
Projects
None yet
Development

No branches or pull requests

4 participants