Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[procstat] why keep these meaningless fields #11768

Closed
Karmenzind opened this issue Sep 6, 2022 · 1 comment
Closed

[procstat] why keep these meaningless fields #11768

Karmenzind opened this issue Sep 6, 2022 · 1 comment

Comments

@Karmenzind
Copy link

image

  1. Left side is the code of procstat and the right side is where these fields are from. Why keep these empty values?
  2. What's the meaning of cpu_time_idle for a single process?

image

This struct TimesStat is defined in "cpu.go". Obviously some fields like Idle and Irq are only for CPU context.
But procstat plugin took them all. It's really confusing.

@Hipska
Copy link
Contributor

Hipska commented Sep 19, 2022

You are definitely right, they are kept because of backward compatibility or it has not come to attention they are always empty.

You can choose to drop these fields by doing fielddrop on the input config.

You can also create a PR that removes these useless fields, it can then internally be discussed if this is accepted now or for upcoming 2.0 release.

@powersj powersj closed this as not planned Won't fix, can't repro, duplicate, stale Dec 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants