Skip to content

Commit

Permalink
Improve Azure Managed Instance support + more in sqlserver input (#4642)
Browse files Browse the repository at this point in the history
  • Loading branch information
m82labs authored and danielnelson committed Sep 12, 2018
1 parent 6a60e3f commit b43165f
Show file tree
Hide file tree
Showing 4 changed files with 211 additions and 117 deletions.
35 changes: 23 additions & 12 deletions Gopkg.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion Gopkg.toml
Original file line number Diff line number Diff line change
Expand Up @@ -183,7 +183,7 @@
branch = "master"

[[constraint]]
name = "github.com/zensqlmonitor/go-mssqldb"
name = "github.com/denisenkom/go-mssqldb"
branch = "master"

[[constraint]]
Expand Down
15 changes: 12 additions & 3 deletions plugins/inputs/sqlserver/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,17 @@ The new (version 2) metrics provide:
- *TempDB*: Free space, Version store usage, Active temp tables, temp table creation rate, + more
- *Resource Governor*: CPU Usage, Requests/sec, Queued Requests, and Blocked tasks per workload group + more
- *Server properties*: Number of databases in all possible states (online, offline, suspect, etc.), cpu count, physical memory, SQL Server service uptime, and SQL Server version
- *Wait stats*: Wait time in ms, number of waiting tasks, resource wait time, signal wait time, max wait time in ms, wait type, and wait category. The waits are categorized using the sasme categories used in Query Store.
- *Wait stats*: Wait time in ms, number of waiting tasks, resource wait time, signal wait time, max wait time in ms, wait type, and wait category. The waits are categorized using the same categories used in Query Store.
- *Azure Managed Instances*
- Stats from `sys.server_resource_stats`:
- cpu_count
- server_memory
- sku
- engine_edition
- hardware_type
- total_storage_mb
- available_storage_mb
- uptime

The following metrics can be used directly, with no delta calculations:
- SQLServer:Buffer Manager\Buffer cache hit ratio
Expand Down Expand Up @@ -129,5 +139,4 @@ The following metrics can be used directly, with no delta calculations:
- SQLServer:Workload Group Stats\Requests completed/sec

Version 2 queries have the following tags:
- `sql_instance`: Physical host and instance name (hostname:instance)

- `sql_instance`: Physical host and instance name (hostname:instance)
Loading

0 comments on commit b43165f

Please sign in to comment.