fix: corrrectly return 4XX errors instead of 5XX errors (#24519) #24534
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HTTP 5XX errors were being returned incorrectly from BoltDB errors that were actually bad requests, e.g., names that were too long for buckets, users, and organizations. Map BoltDB errors to correct Influx errors and return 4XX errors where appropriate. Also add op codes to more errors (cherry picked from commit a3fd489)
davidby-influx
added
kind/bug
area/api
area/2.x
jeffreyssmith2nd
approved these changes
Dec 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HTTP 5XX errors were being returned incorrectly
from BoltDB errors that were actually bad
requests, e.g., names that were too long for
buckets, users, and organizations. Map
BoltDB errors to correct Influx errors and
return 4XX errors where appropriate. Also add
op codes to more errors
(cherry picked from commit a3fd489