feat(cmd/influx): allow setting shard-group durations for buckets via API and CLI #20911
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danxmoran
changed the title
8 tasks
danxmoran
force-pushed
the
dm-shard-duration-config-19764
branch
from
904e57a to
b7669f3
Compare
danxmoran
commented
Mar 9, 2021
lesam
reviewed
Mar 10, 2021
| @@ -168,7 +161,7 @@ func (s *BucketClientService) UpdateBucket(ctx context.Context, id influxdb.ID, | |||
| if err != nil { | |||
| return nil, err | |||
| } | |||
| return br.toInfluxDB() | |||
| return br.toInfluxDB(), nil | |||
There was a problem hiding this comment.
Is the PatchJSON call being called in the tests above? Especially for nil retention duration / shard group duration?
There was a problem hiding this comment.
Yes, in cmd/influxd/launcher/storage_test.go. The BucketService created here is a wrapper around the HTTP client. PatchJSON is called as part of the update step in each test case. All of the existing cases only set retention duration XOR shard-group duration. I need to add a case that sets both. Case updating both values is added now.
lesam
reviewed
Mar 10, 2021
danxmoran
commented
Mar 11, 2021
| }, | ||
| } | ||
|
|
||
| for _, tt := range tests { |
There was a problem hiding this comment.
Lazily copy-pasted from testing/bucket_service.go
lesam
reviewed
Mar 11, 2021
lesam
reviewed
Mar 11, 2021
lesam
approved these changes
Mar 11, 2021
danxmoran
force-pushed
the
dm-shard-duration-config-19764
branch
from
76ef185 to
eff0ad5
Compare
This was referenced Mar 11, 2021
bednar
added a commit
to influxdata/influxdb-clients-apigen
that referenced
this pull request
Mar 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #19764
Builds off of #20620 to address review feedback and ensure shard-group duration is tracked in metadata, so the CLI can report on it in all cases.