fix: various improvements to setup command #20155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danxmoran
reviewed
Nov 23, 2020
ayang64
reviewed
Nov 23, 2020
|
I'll get this one over the finish line. |
When checking for existing configs, check the length of the array after parsing. There could be an empty config file present. If --name was specified then use that as the configuration name, regardless of whether or not there are existing configs. Allow a 0 (infinite) retention to be specified with --retention when in interactive mode.
danxmoran
force-pushed
the
fix/setup-command
branch
2 times, most recently
from
d7f8d98 to
8465857
Compare
danxmoran
force-pushed
the
fix/setup-command
branch
from
8465857 to
839c30c
Compare
danxmoran
added a commit
that referenced
this pull request
Dec 2, 2020
When checking for existing configs, check the length of the array after parsing. There could be an empty config file present. If --name was specified then use that as the configuration name, regardless of whether or not there are existing configs. Allow a 0 (infinite) retention to be specified with --retention when in interactive mode. Co-authored-by: Dan Moran <dmoran@influxdata.com>
|
Thanks @danxmoran and @ayang64. Came back today to work on it and saw you took care of it. I've been wrapping up a move into a new apartment and haven't been moving on things as quickly as I'd like! |
|
No worries 😄 hope the move went well! |
danxmoran
added a commit
that referenced
this pull request
Dec 3, 2020
When checking for existing configs, check the length of the array after parsing. There could be an empty config file present. If --name was specified then use that as the configuration name, regardless of whether or not there are existing configs. Allow a 0 (infinite) retention to be specified with --retention when in interactive mode. Co-authored-by: Dan Moran <dmoran@influxdata.com>
danxmoran
added a commit
that referenced
this pull request
Dec 3, 2020
When checking for existing configs, check the length of the array after parsing. There could be an empty config file present. If --name was specified then use that as the configuration name, regardless of whether or not there are existing configs. Allow a 0 (infinite) retention to be specified with --retention when in interactive mode. Co-authored-by: Dan Moran <dmoran@influxdata.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When checking for existing configs, check the length of the array after
parsing. There could be an empty config file present.
If --name was specified then use that as the configuration name, regardless of
whether or not there are existing configs.
Allow a 0 (infinite) retention to be specified with --retention when in
interactive mode.