Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add locking during tsi iterator creation. #20008

Merged
merged 1 commit into from
Nov 12, 2020

Conversation

benbjohnson
Copy link
Contributor

@benbjohnson benbjohnson commented Nov 12, 2020

This commit fixes a locking issue that caused the TestShard_WritePoints_FieldConflictConcurrent
test to fail.

Closes #19664

link to the PR (not the Issue)

This commit fixes a locking issue that caused the `TestShard_WritePoints_FieldConflictConcurrent`
test to fail.
@benbjohnson benbjohnson self-assigned this Nov 12, 2020
Copy link
Contributor

@stuartcarnie stuartcarnie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! This data race seems to have been cropping up a lot more in CI lately

@benbjohnson benbjohnson merged commit 65f42de into master Nov 12, 2020
@benbjohnson benbjohnson deleted the flakey-test-field-conflict-concurrent branch November 12, 2020 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Possible data race in tsi1 package
2 participants