Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(upgrade): delete references to 'security script' in upgrade command #19924

Merged
merged 2 commits into from
Nov 6, 2020

Conversation

danxmoran
Copy link
Contributor

@danxmoran danxmoran commented Nov 6, 2020

Closes #19921

"Security script" is unused / irrelevant since #19854

  • CHANGELOG.md updated with a link to the PR (not the Issue)
  • Well-formatted commit messages
  • Rebased/mergeable
  • Tests pass
  • http/swagger.yml updated (if modified Go structs or API)
  • Feature flagged (if modified API)
  • Documentation updated or issue created (provide link to issue/pr)
  • Signed CLA (if not already signed)

// securityScriptHelper is a helper used by `generate-security-script` command.
type securityScriptHelper struct {
// securityUpgradeHelper is a helper used by `upgrade` command.
type securityUpgradeHelper struct {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The logic in this struct's methods still seemed to be useful, so I just renamed it to avoid future confusion

Copy link
Contributor

@docmerlin docmerlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ayang64
Copy link
Contributor

ayang64 commented Nov 6, 2020

LGTM

@danxmoran danxmoran merged commit a89041b into master Nov 6, 2020
@danxmoran danxmoran deleted the dm-no-more-security-script-19921 branch November 6, 2020 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

remove security script from help
3 participants