Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(influx): add missing description field to auth output #19331

Merged
merged 1 commit into from
Aug 14, 2020
Merged

fix(influx): add missing description field to auth output #19331

merged 1 commit into from
Aug 14, 2020

Conversation

jsteenb2
Copy link
Contributor

@jsteenb2 jsteenb2 commented Aug 14, 2020 •
edited
Loading

this PR also extends the create auth to include ability to
set the auth description

closes: #19156

@jsteenb2 jsteenb2 requested a review from russorat August 14, 2020 18:50
@jsteenb2
fix(influx): add missing description field to auth output
add8dda 
this PR also extends the create auth to include ability to
set the auth description

closes: #19156
@jsteenb2 jsteenb2 requested a review from sanderson August 14, 2020 18:52
russorat
russorat approved these changes Aug 14, 2020
View reviewed changes
Copy link
Contributor

@russorat russorat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yesssss! LGTM

@jsteenb2 jsteenb2 merged commit 99ab43f into master Aug 14, 2020
@jsteenb2 jsteenb2 deleted the fix/token_descs branch August 14, 2020 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@russorat russorat russorat approved these changes

@sanderson sanderson Awaiting requested review from sanderson

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

cli: listing auths (tokens) should display the description
2 participants
@jsteenb2 @russorat