Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(influx): support days as duration type #18658

Merged
merged 2 commits into from
Jun 23, 2020
Merged

fix(influx): support days as duration type #18658

merged 2 commits into from
Jun 23, 2020

Conversation

jsteenb2
Copy link
Contributor

@jsteenb2 jsteenb2 commented Jun 23, 2020 •
edited
Loading

Closes #18639

@jsteenb2 jsteenb2 requested a review from sanderson June 23, 2020 02:43
@jsteenb2 jsteenb2 force-pushed the 18639/influx_durations branch from fb2c217 to fbcd02a Compare June 23, 2020 02:43
@jsteenb2 jsteenb2 requested a review from hoorayimhelping June 23, 2020 02:43
@jsteenb2 jsteenb2 force-pushed the 18639/influx_durations branch from fbcd02a to a86266f Compare June 23, 2020 02:44
sanderson
sanderson approved these changes Jun 23, 2020
View reviewed changes
Copy link
Contributor

@sanderson sanderson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jsteenb2 jsteenb2 force-pushed the 18639/influx_durations branch from a86266f to a5aceb6 Compare June 23, 2020 02:45
@sanderson
Copy link
Contributor

sanderson commented Jun 23, 2020 •
edited
Loading

@kelseiv FYI 👆

@jsteenb2 jsteenb2 force-pushed the 18639/influx_durations branch from a5aceb6 to 495191e Compare June 23, 2020 02:46
@jsteenb2
Copy link
Contributor Author

@sanderson / @kelseiv I decided to just get days in for now. I am not sure how to integrate the months/years into this with all the special cases involved (short months (feb), leap year, yada yada). WIll need to follow up, if product wants it, to support the month/year duration.

@jsteenb2 jsteenb2 merged commit 3c14db1 into master Jun 23, 2020
@jsteenb2 jsteenb2 deleted the 18639/influx_durations branch June 23, 2020 03:07
@kelseiv
Copy link
Contributor

kelseiv commented Jun 23, 2020

Thank you, @sanderson @jsteenb2. That was quick! Makes sense. Day seems most important per the reasons in @abalone23 's request. It sounds like week is next in importance given we supported that in 1.x.
Although years and months are more complex to implement, it seems to make sense to eventually support retention policies using any Flux duration literal, as you suggested Johnny.

@jsteenb2
Copy link
Contributor Author

I forgot about the week duration. I put up a PR to add that, is a trivial extension to the existing.

#18659

@jsteenb2
Copy link
Contributor Author

we're good now, week is merged :-)

@kelseiv kelseiv mentioned this pull request Jun 23, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sanderson sanderson sanderson approved these changes

@hoorayimhelping hoorayimhelping Awaiting requested review from hoorayimhelping

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Influx CLI - allow bucket creation RP in 'd' units (days)
3 participants
@jsteenb2 @sanderson @kelseiv